chore: update_root, sync_root_with_cwd, refactor with move_missing_val #1359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-courtis
commented
Jun 19, 2022
kyazdani42
reviewed
Jun 19, 2022
|
I haven't forgotten about the git concurrency... just poking away until I find a nice solution. |
kyazdani42
reviewed
Jun 20, 2022
lua/nvim-tree/utils.lua
Outdated
| -- @param dst_pos value pos | ||
| function M.move_missing_val(src, src_path, src_pos, dst, dst_path, dst_pos) | ||
| if | ||
| not pcall(vim.validate, { |
There was a problem hiding this comment.
i think we can deliberaly fail when this function is called with the wrong arguments instead of silently returning ?
There was a problem hiding this comment.
That works. Are you thinking of a warning message?
Signing off for now... I'll get to this on the weekend.
There was a problem hiding this comment.
Updated. This is a nice pattern we can use more.
[NvimTree] move_missing_val: dst_path: expected string, got number
kyazdani42
approved these changes
Jun 25, 2022
|
Thanks @alex-courtis, please rebase :) |
ellsclytn
added a commit
to ellsclytn/dotfiles
that referenced
this pull request
Jul 31, 2022
update_to_buf_dir is now replaced with hijack_directories. That said, I never had any use fot it. update_cwd was depreated in favour of sync_root_with_cwd. nvim-tree/nvim-tree.lua#1359
Almo7aya
pushed a commit
to Almo7aya/nvim-tree.lua
that referenced
this pull request
Oct 11, 2022
nvim-tree#1359) * chore: opts.update_focused_file.update_cwd -> update_root * chore: opts.update_cwd -> sync_root_with_cwd * chore: refactor options with utils move_missing_val * chore: refactor options with utils move_missing_val * chore: refactor options with utils move_missing_val * chore: refactor options with utils move_missing_val * chore: refactor options with utils move_missing_val * chore: refactor options with utils move_missing_val
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1342 , refactoring some options
move_missing_valtook too long to write :(validate_optionsis the bit I'd like you to review.